Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15632 )
Change subject: [build] Fix boost compilation on latest macOS Catalina update ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15632/1/thirdparty/patches/boost-coalesce-templates-darwin.patch File thirdparty/patches/boost-coalesce-templates-darwin.patch: http://gerrit.cloudera.org:8080/#/c/15632/1/thirdparty/patches/boost-coalesce-templates-darwin.patch@11 PS1, Line 11: - # - GCC 4.2 and higher in Darwin does not have -Wno-long-double. : - if $(real-version) < "4.2.0" : - { : - flags darwin.compile OPTIONS $(condition) : -Wno-long-double ; : - } Curious why remove this compiler flag? -- To view, visit http://gerrit.cloudera.org:8080/15632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6bb488dcadf215be708ae1b1e89ddd77bd30074 Gerrit-Change-Number: 15632 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 01 Apr 2020 19:17:31 +0000 Gerrit-HasComments: Yes
