Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15632 )
Change subject: [build] Fix boost compilation on latest macOS Catalina update ...................................................................... Patch Set 1: Code-Review+1 > Patch Set 1: > > I took a look at this diff > https://github.com/zcash/zcash/pull/4334/commits/2d2b7a1be722204457d6bd08b824c8fe332f0467 > but didn't understand what was actually updated. Looks same to me :( Oh it's commenting out those lines. Third party built successfully for me on Mac OS 10.15.4. So this patch works. I didn't understand the change to be honest. Clang is used on Mac OS and it appears gcc is symlinked to clang. So the version difference between clang and gcc is what causes this check to be bad? -- To view, visit http://gerrit.cloudera.org:8080/15632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6bb488dcadf215be708ae1b1e89ddd77bd30074 Gerrit-Change-Number: 15632 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 01 Apr 2020 19:34:06 +0000 Gerrit-HasComments: No
