Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15629 )
Change subject: [postgres] Deflake MiniPostgres tests ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/15629/6/src/kudu/postgres/mini_postgres.cc File src/kudu/postgres/mini_postgres.cc: http://gerrit.cloudera.org:8080/#/c/15629/6/src/kudu/postgres/mini_postgres.cc@146 PS6, Line 146: TestConnection nit: maybe rename this to WaitForReady() or something? http://gerrit.cloudera.org:8080/#/c/15629/6/src/kudu/postgres/mini_postgres.cc@147 PS6, Line 147: FromMilliseconds nit: can use FromSeconds() http://gerrit.cloudera.org:8080/#/c/15629/6/src/kudu/postgres/mini_postgres.cc@162 PS6, Line 162: if ((MonoTime::Now() - start) > kTimeout) { : break; : } nit: would be simpler as MonoTime timeout = Now + delta Status s; while (Now < timeout) { s = psql.Start...Wait() if (s.ok()) return s; SleepFor(100ms); } return s; // or wrap this in a Status::TimedOut() -- To view, visit http://gerrit.cloudera.org:8080/15629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5106b3e2aeb9dabad9a7ee0b17059c1df2042bb4 Gerrit-Change-Number: 15629 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 01 Apr 2020 21:53:08 +0000 Gerrit-HasComments: Yes
