Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15629 )
Change subject: [postgres] Deflake MiniPostgres tests ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/15629/6/src/kudu/postgres/mini_postgres.cc File src/kudu/postgres/mini_postgres.cc: http://gerrit.cloudera.org:8080/#/c/15629/6/src/kudu/postgres/mini_postgres.cc@146 PS6, Line 146: WaitForReady() > nit: maybe rename this to WaitForReady() or something? Done http://gerrit.cloudera.org:8080/#/c/15629/6/src/kudu/postgres/mini_postgres.cc@147 PS6, Line 147: > nit: can use FromSeconds() Done http://gerrit.cloudera.org:8080/#/c/15629/6/src/kudu/postgres/mini_postgres.cc@162 PS6, Line 162: : return Status::TimedOut(s.ToString()); : } > nit: If you do go down this route, could you call it 'deadline' instead of Done -- To view, visit http://gerrit.cloudera.org:8080/15629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5106b3e2aeb9dabad9a7ee0b17059c1df2042bb4 Gerrit-Change-Number: 15629 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 02 Apr 2020 09:23:49 +0000 Gerrit-HasComments: Yes
