Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15635 )
Change subject: rowblock: use BMI instruction set when available for GetSelectedRows ...................................................................... Patch Set 1: Code-Review+1 (1 comment) IWYU isn't yet happy and wants one more header to be included: +#include <emmintrin.h> http://gerrit.cloudera.org:8080/#/c/15635/1/src/kudu/common/rowblock.cc File src/kudu/common/rowblock.cc: http://gerrit.cloudera.org:8080/#/c/15635/1/src/kudu/common/rowblock.cc@92 PS1, Line 92: static bool has_bmi = base::CPU().has_bmi(); nit: maybe, add const? const static bool has_bmi = ...; ? -- To view, visit http://gerrit.cloudera.org:8080/15635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ec74bc5db07c18d0e36de14a2343f49fc5c2859 Gerrit-Change-Number: 15635 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 02 Apr 2020 15:21:50 +0000 Gerrit-HasComments: Yes
