Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15635 )
Change subject: rowblock: use BMI instruction set when available for GetSelectedRows ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15635/1/src/kudu/common/rowblock.cc File src/kudu/common/rowblock.cc: http://gerrit.cloudera.org:8080/#/c/15635/1/src/kudu/common/rowblock.cc@92 PS1, Line 92: static bool static const bool http://gerrit.cloudera.org:8080/#/c/15635/1/src/kudu/common/rowblock.cc@114 PS1, Line 114: if (has_bmi) { : GetSelectedRowsInternal<true>(&bitmap_[0], n_bytes_, selected.data()); : } else { : GetSelectedRowsInternal<false>(&bitmap_[0], n_bytes_, selected.data()); : } I think further "if has_bmi" check can be avoided by explicitly declaring default version of the function outside the #ifdef and let CPU dispatch the function dynamically. template __attribute__((target("default"))) void GetSelectedRowsInternal<false>(const uint8_t* __restrict__ bitmap, int n_bytes, uint16_t* __restrict__ dst); -- To view, visit http://gerrit.cloudera.org:8080/15635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ec74bc5db07c18d0e36de14a2343f49fc5c2859 Gerrit-Change-Number: 15635 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 02 Apr 2020 15:28:26 +0000 Gerrit-HasComments: Yes
