Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 )
Change subject: KUDU-3081 Add Kerberos support to MiniRanger ...................................................................... Patch Set 14: (5 comments) http://gerrit.cloudera.org:8080/#/c/15601/3/src/kudu/integration-tests/master_sentry-itest.cc File src/kudu/integration-tests/master_sentry-itest.cc: http://gerrit.cloudera.org:8080/#/c/15601/3/src/kudu/integration-tests/master_sentry-itest.cc@375 PS3, Line 375: void SetUp() override { > I think using NullGroupsMapping is good for now, but eventually we would wa Hm we would either need MiniLdap for that or manipulate real groups/users on the host. I think there's also a test class where we can set up group mappings manually, but then we would need to expose methods to manipulate that in the Ranger subprocess. Anyway, we don't need to decide that now. http://gerrit.cloudera.org:8080/#/c/15601/13/src/kudu/mini-cluster/external_mini_cluster.cc.orig File src/kudu/mini-cluster/external_mini_cluster.cc.orig: PS13: > Accidentally added? Done http://gerrit.cloudera.org:8080/#/c/15601/13/src/kudu/postgres/mini_postgres.cc.orig File src/kudu/postgres/mini_postgres.cc.orig: PS13: > Same here? Done http://gerrit.cloudera.org:8080/#/c/15601/13/src/kudu/ranger/mini_ranger.cc.orig File src/kudu/ranger/mini_ranger.cc.orig: PS13: > Same here? Done http://gerrit.cloudera.org:8080/#/c/15601/13/src/kudu/ranger/mini_ranger.h.orig File src/kudu/ranger/mini_ranger.h.orig: PS13: > Also this one? Done -- To view, visit http://gerrit.cloudera.org:8080/15601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32118780ad912791fe5e371004345428b6459549 Gerrit-Change-Number: 15601 Gerrit-PatchSet: 14 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 02 Apr 2020 17:34:22 +0000 Gerrit-HasComments: Yes
