Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15638 )

Change subject: KUDU-3099: Remove System.exit() calls from 
KuduBackup/KuduRestore
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15638/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala:

http://gerrit.cloudera.org:8080/#/c/15638/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala@174
PS1, Line 174: thrown
I think this is a typo and fails to compile. You can edit and test by using the 
below in the java directory:
`./gradlew :kudu-backup:check`

I also suspect you will need to adjust the tests slightly. Like here for 
example: 
https://github.com/apache/kudu/blob/master/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala#L698



--
To view, visit http://gerrit.cloudera.org:8080/15638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d1b4796b6280adecd7dab685a0281af6b2570ce
Gerrit-Change-Number: 15638
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 03 Apr 2020 20:51:14 +0000
Gerrit-HasComments: Yes

Reply via email to