[email protected] has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15646
Change subject: KUDU-3099: Remove System.exit() calls from KuduBackup/KuduRestore ...................................................................... KUDU-3099: Remove System.exit() calls from KuduBackup/KuduRestore The System.exit() calls have a side effect that can cause Spark to fail even if the run function returns 0 on success. Rather than call System.exit() the run() method will return true on a successful run. We then throw a RuntimeException() in main if we find that run() failed, otherwise we call SparkSession's stop() method to cleanly shutdown Spark. Unfortunately the issue isn't easy to reproduce but we had one environment exhibiting the problem and we confirmed that this patch fixes the issue. TestKuduBackup.scala was modified where assertFalse() is used to check for failure and assertTrue() for success. Change-Id: I7014c3c4eac0f622afb0508cd97226b1d32fb904 --- M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala 3 files changed, 36 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/15646/1 -- To view, visit http://gerrit.cloudera.org:8080/15646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7014c3c4eac0f622afb0508cd97226b1d32fb904 Gerrit-Change-Number: 15646 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]>
