Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15671 )
Change subject: KUDU-3078 Refactor Sentry integration tests ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15671/2/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/15671/2/src/kudu/integration-tests/master_hms-itest.cc@80 PS2, Line 80: hms_opts.enable_kerberos = EnableKerberos(); : hms_opts.service_principal = "hive"; : harness_.hms_client_.reset(new HmsC > hm maybe I'm missing something, but how would I reset hms_client_ if I acce It probably wouldn't hurt to move this into the harness itself with some HmsITestHarness::ResetHmsClient(address, opts) or somesuch. http://gerrit.cloudera.org:8080/#/c/15671/2/src/kudu/integration-tests/master_sentry-itest.cc File src/kudu/integration-tests/master_sentry-itest.cc: http://gerrit.cloudera.org:8080/#/c/15671/2/src/kudu/integration-tests/master_sentry-itest.cc@414 PS2, Line 414: > maybe I misunderstood what you're suggesting, but wouldn't that be duplicat Would something like this work? SentryITestHarness { /* looks like it does now for the most part */ virtual ExternalMiniClusterOptions GetClusterOpts() { /* opts we have in SetUpCluster */ } void SetUpCluster() { ... SetUpClusterWithOpts(GetClusterOpts()); ... } }; SentryITestHarnessWithCache : public SentryITestHarness { ExternalMiniClusterOptions GetClusterOpts() override { ExternalMiniClusterOptions opts = SentryITestHarness::GetClusterOpts(); // add cache gflag return opts; } }; It's a little more legwork, but it helps decouple the harness and test a bit, which I find appealing. -- To view, visit http://gerrit.cloudera.org:8080/15671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieff25eaf7a41cf7d8fe965738907e67bbd9b9051 Gerrit-Change-Number: 15671 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 07 Apr 2020 21:08:58 +0000 Gerrit-HasComments: Yes
