Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15671 )
Change subject: KUDU-3078 Refactor Sentry integration tests ...................................................................... Patch Set 7: (15 comments) http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/master_hms-itest.cc@107 PS6, Line 107: return HmsITestHarness::CreateKuduTable(database_name, table_name, client_, timeout); > warning: static member accessed through instance [readability-static-access Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/master_sentry-itest.cc File src/kudu/integration-tests/master_sentry-itest.cc: http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/master_sentry-itest.cc@211 PS6, Line 211: static Status CreateTable(const OperationParams& p, > warning: method 'CreateTable' can be made static [readability-convert-membe Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/master_sentry-itest.cc@257 PS6, Line 257: static Status GetTableLocations(const OperationParams& p, > warning: method 'GetTableLocations' can be made static [readability-convert Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc File src/kudu/integration-tests/ts_sentry-itest.cc: http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc@249 PS6, Line 249: constexpr int kNumUsers = 3; > warning: 'kNumUsers' is a static definition in anonymous namespace; static Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc@250 PS6, Line 250: constexpr const char* kAdminGroup = "admin"; > warning: 'kAdminGroup' is a static definition in anonymous namespace; stati Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc@252 PS6, Line 252: constexpr int kNumTables = 3; > warning: 'kNumTables' is a static definition in anonymous namespace; static Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc@253 PS6, Line 253: constexpr int kNumColsPerTable = 3; > warning: 'kNumColsPerTable' is a static definition in anonymous namespace; Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc@254 PS6, Line 254: constexpr const char* kDb = "db"; > warning: 'kDb' is a static definition in anonymous namespace; static is red Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc@255 PS6, Line 255: constexpr const char* kTablePrefix = "table"; > warning: 'kTablePrefix' is a static definition in anonymous namespace; stat Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc@256 PS6, Line 256: constexpr const char* kAdminRole = "kudu-admin"; > warning: 'kAdminRole' is a static definition in anonymous namespace; static Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc@258 PS6, Line 258: constexpr int kAuthzTokenTTLSecs = 1; > warning: 'kAuthzTokenTTLSecs' is a static definition in anonymous namespace Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc@259 PS6, Line 259: constexpr int kAuthzCacheTTLMultiplier = 3; > warning: 'kAuthzCacheTTLMultiplier' is a static definition in anonymous nam Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc@269 PS6, Line 269: ExternalMiniClusterOptions)>& cluster_start_func) { > warning: the parameter 'cluster_start_func' is copied for each invocation b Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc@325 PS6, Line 325: Status CreateTable(const string& table_ident, const shared_ptr<KuduClient>& client) { > warning: the const qualified parameter 'client' is copied for each invocati Done http://gerrit.cloudera.org:8080/#/c/15671/6/src/kudu/integration-tests/ts_sentry-itest.cc@360 PS6, Line 360: harness_.SetUp([&] (const ExternalMiniClusterOptions& opts) -> > warning: the parameter 'opts' is copied for each invocation but only used a Done -- To view, visit http://gerrit.cloudera.org:8080/15671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieff25eaf7a41cf7d8fe965738907e67bbd9b9051 Gerrit-Change-Number: 15671 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 08 Apr 2020 20:05:24 +0000 Gerrit-HasComments: Yes
