Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15677 )
Change subject: tserver: add locking around an RPC's usage of a Scanner ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/15677/2/src/kudu/tserver/scanners-test.cc File src/kudu/tserver/scanners-test.cc: http://gerrit.cloudera.org:8080/#/c/15677/2/src/kudu/tserver/scanners-test.cc@90 PS2, Line 90: auto access = s2->LockForAccess(); > nit: mind noting that locking updates the access time, which is what we act Done http://gerrit.cloudera.org:8080/#/c/15677/2/src/kudu/tserver/scanners.h File src/kudu/tserver/scanners.h: http://gerrit.cloudera.org:8080/#/c/15677/2/src/kudu/tserver/scanners.h@255 PS2, Line 255: // Check result.owns_lock() to see if the lock was successful. : AccessLock TryLockForAccess() WARN_UNUSED_RESULT { : return AccessLock(this); : } > Should be using the other constructor? woops! http://gerrit.cloudera.org:8080/#/c/15677/2/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/15677/2/src/kudu/tserver/tablet_server-test.cc@2521 PS2, Line 2521: threads.emplace_back( : [&]() { : while (!done) { : mini_server_->server()->scanner_manager()->ListScans(); : } : }); > nit: mind commenting why this is important for the test? Is this just anoth Done -- To view, visit http://gerrit.cloudera.org:8080/15677 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3591e85a07aefadaf7fb05768109c8a261a8828e Gerrit-Change-Number: 15677 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 16 Apr 2020 17:56:35 +0000 Gerrit-HasComments: Yes
