Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15795 )
Change subject: [warning] Fixed GCC warning "control reaches end of non-void function" ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15795/1/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: http://gerrit.cloudera.org:8080/#/c/15795/1/src/kudu/util/net/sockaddr.cc@152 PS1, Line 152: // to quite GCC warning: control reaches end of non-void function : return "unknown"; It'd be better to add default switch case instead. -- To view, visit http://gerrit.cloudera.org:8080/15795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c22cbc18892374966975bee9e50f4119580006b Gerrit-Change-Number: 15795 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 24 Apr 2020 01:43:53 +0000 Gerrit-HasComments: Yes
