Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15795 )
Change subject: [warning] Fixed GCC warning "control reaches end of non-void function" ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15795/3/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: http://gerrit.cloudera.org:8080/#/c/15795/3/src/kudu/util/net/sockaddr.cc@154 PS3, Line 154: return "unknown"; Since the 'default' case is now added, it seems clang won't report any warnings once a new non-handled enumeration element is added into UnixAddressType (adding a new enumeration element is highly unlikely, but anyways). Maybe, we should do LOG(FATAL) << "unknown unix socket address type"; return "unknown"; // unreachable instead? -- To view, visit http://gerrit.cloudera.org:8080/15795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c22cbc18892374966975bee9e50f4119580006b Gerrit-Change-Number: 15795 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Thu, 30 Apr 2020 01:01:50 +0000 Gerrit-HasComments: Yes
