Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15981 )
Change subject: replace shared_ptr(new T) with make_shared<T>() ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15981/5/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/15981/5/src/kudu/tablet/tablet.cc@320 PS5, Line 320: .reset Why change to reset here? -- To view, visit http://gerrit.cloudera.org:8080/15981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bcca0287d484472f7cc616f553060fe83faab1a Gerrit-Change-Number: 15981 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 24 May 2020 01:43:17 +0000 Gerrit-HasComments: Yes
