Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15983 )
Change subject: Support columnar layout row format flag and result set iteration in Java client. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15983/3/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java: http://gerrit.cloudera.org:8080/#/c/15983/3/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java@34 PS3, Line 34: public abstract class RowResultIterator extends KuduRpcResponse implements Iterator<RowResult>, > Given this is a public class, I don't think we can change it to be abstract Worth checking with benchmarks that you don't regress the existing code path, though. Probably the JVM will be smart enough to devirtualize and inline through composition but I'd be a little nervous to just do it without checking. -- To view, visit http://gerrit.cloudera.org:8080/15983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I580c9bb48e797ca8de9d88e7892df6860eed7070 Gerrit-Change-Number: 15983 Gerrit-PatchSet: 3 Gerrit-Owner: Shuping Zhou <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 27 May 2020 04:01:33 +0000 Gerrit-HasComments: Yes
