Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16031 )
Change subject: KUDU-1802: Avoid call to master when deserializing scan tokens ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/16031/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16031/2//COMMIT_MSG@24 PS2, Line 24: producing writing ? http://gerrit.cloudera.org:8080/#/c/16031/2/src/kudu/client/client.proto File src/kudu/client/client.proto: http://gerrit.cloudera.org:8080/#/c/16031/2/src/kudu/client/client.proto@29 PS2, Line 29: optional string table_id = 1; : optional string table_name = 2; If this structure is used only in the context of ScanTokenPB where table_id and/or table_name are already present, maybe these fields are not needed? Also, if getting rid of table_id/table_name and given the fact it's used only as a part of ScanTokenPB, maybe add the rest of the fields as they are into the ScanTokenPB message? http://gerrit.cloudera.org:8080/#/c/16031/2/src/kudu/client/client.proto@31 PS2, Line 31: required int32 num_replicas = 3; : : required SchemaPB schema = 4; : required PartitionSchemaPB partition_schema = 5; If thinking about switching to protobuf3, maybe it's worth turning these into optional fields as well? http://gerrit.cloudera.org:8080/#/c/16031/2/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/16031/2/src/kudu/client/scan_token-internal.cc@119 PS2, Line 119: TableMetadataPB +1 Consider using const reference here instead of copying. -- To view, visit http://gerrit.cloudera.org:8080/16031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c1b8392de37dd5e8b7bd8b78a21603ff8b1d1b Gerrit-Change-Number: 16031 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 04 Jun 2020 22:27:48 +0000 Gerrit-HasComments: Yes
