Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16031 )
Change subject: KUDU-1802: Avoid call to master when deserializing scan tokens ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/16031/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16031/2//COMMIT_MSG@24 PS2, Line 24: producing > writing ? Done http://gerrit.cloudera.org:8080/#/c/16031/2/src/kudu/client/client.proto File src/kudu/client/client.proto: http://gerrit.cloudera.org:8080/#/c/16031/2/src/kudu/client/client.proto@29 PS2, Line 29: optional string table_id = 1; : optional string table_name = 2; > If this structure is used only in the context of ScanTokenPB where table_id The goal of including them here was to encapsulate all the table metadata required to create a KuduTable object client side. It simplifies the semantics around when to use table metadata and when to fallback to calling GetSchema. I also plan to use this message for more general purpose metadata tokens as tracked in KUDU-3135. http://gerrit.cloudera.org:8080/#/c/16031/2/src/kudu/client/client.proto@31 PS2, Line 31: required int32 num_replicas = 3; : : required SchemaPB schema = 4; : required PartitionSchemaPB partition_schema = 5; > If thinking about switching to protobuf3, maybe it's worth turning these in Done http://gerrit.cloudera.org:8080/#/c/16031/1/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/16031/1/src/kudu/client/scan_token-internal.cc@117 PS1, Line 117: sp::shared_ptr<KuduTable> table; > warning: the variable 'metadata' is copy-constructed from a const reference Done http://gerrit.cloudera.org:8080/#/c/16031/2/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/16031/2/src/kudu/client/scan_token-internal.cc@119 PS2, Line 119: const TableMetadataPB metadata = message.table_metadata(); > warning: the const qualified variable 'metadata' is copy-constructed from a Done -- To view, visit http://gerrit.cloudera.org:8080/16031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c1b8392de37dd5e8b7bd8b78a21603ff8b1d1b Gerrit-Change-Number: 16031 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 04 Jun 2020 22:41:04 +0000 Gerrit-HasComments: Yes
