Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/16035 )
Change subject: [consensus] use std::atomic in raft_consensus.{cc,h}
......................................................................
Patch Set 1:
(1 comment)
> Is there a reason to use kudu/util/atomic.h elsewhere in the server
> code or should it all be cleaned up?
I guess there were some differences how signed types are handled and other
subtleties, but frankly I haven't looked across all the code to understand
whether it's crucial to use kudu/util/atomic.h instead of std::atomic.
http://gerrit.cloudera.org:8080/#/c/16035/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
http://gerrit.cloudera.org:8080/#/c/16035/1/src/kudu/consensus/raft_consensus.cc@631
PS1, Line 631: leader_transfer_in_progress_ = true;
> the default memory order for store is "release" but we used to use "acquire
Good point: it's a functional change. However, I don't think the former memory
order was crucial here, and code performs as needed by the logic of this method.
--
To view, visit http://gerrit.cloudera.org:8080/16035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14214ca486b86b241f1b6fcf8842867a6bf1459a
Gerrit-Change-Number: 16035
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Fri, 05 Jun 2020 16:14:24 +0000
Gerrit-HasComments: Yes
