Todd Lipcon has posted comments on this change. (
http://gerrit.cloudera.org:8080/16035 )
Change subject: [consensus] use std::atomic in raft_consensus.{cc,h}
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16035/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
http://gerrit.cloudera.org:8080/#/c/16035/1/src/kudu/consensus/raft_consensus.cc@631
PS1, Line 631: leader_transfer_in_progress_ = true;
the default memory order for store is "release" but we used to use "acquire"
here. The difference is that an 'acquire store' will force an mfence. i'm not
sure if it matters here or if it was a mistake, but this is a functional change
--
To view, visit http://gerrit.cloudera.org:8080/16035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14214ca486b86b241f1b6fcf8842867a6bf1459a
Gerrit-Change-Number: 16035
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Fri, 05 Jun 2020 14:33:08 +0000
Gerrit-HasComments: Yes
