Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16031 )
Change subject: KUDU-1802: Avoid call to master when deserializing scan tokens ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/16031/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16031/7//COMMIT_MSG@23 PS7, Line 23: This doesn’t avoid the need for a call to the master in the case : of writing data to Kudu, that work is tracked by KUDU-3135. : I expect the TableMeta > nit: spacing Done http://gerrit.cloudera.org:8080/#/c/16031/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java: http://gerrit.cloudera.org:8080/#/c/16031/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java@202 PS7, Line 202: ProtobufHelper.pbToPartitionSchema(tableMetadata.getPartitionSchema(), schema); : table = new KuduTable(client.asyncClient, tableMetadata.getTableName(), : tableMetadata.getTableI > nit: spacing in this file too Done http://gerrit.cloudera.org:8080/#/c/16031/7/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/16031/7/src/kudu/client/scan_token-internal.cc@122 PS7, Line 122: kuduSchema > nit: snake_case Done http://gerrit.cloudera.org:8080/#/c/16031/7/src/kudu/client/scan_token-internal.cc@278 PS7, Line 278: le_s > nit: don't need this? Done http://gerrit.cloudera.org:8080/#/c/16031/7/src/kudu/client/scan_token-internal.cc@279 PS7, Line 279: PartitionSchemaPB partition_schema_pb; > nit: can use *mutable_pb() = std::move(pb) to avoid copying. Same below. Done http://gerrit.cloudera.org:8080/#/c/16031/5/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/16031/5/src/kudu/client/scan_token-test.cc@621 PS5, Line 621: ASSERT_OK(tokenWithMetadata->IntoKuduScanner(&scanner_ptr)); > nit: Perhaps we should convert this to some convenience test method like: Done http://gerrit.cloudera.org:8080/#/c/16031/7/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: PS7: > Could you also add a test that hydrates a bunch of scan tokens and checks t Done -- To view, visit http://gerrit.cloudera.org:8080/16031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c1b8392de37dd5e8b7bd8b78a21603ff8b1d1b Gerrit-Change-Number: 16031 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2020 14:27:49 +0000 Gerrit-HasComments: Yes
