Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16031 )
Change subject: KUDU-1802: Avoid call to master when deserializing scan tokens ...................................................................... Patch Set 10: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/16031/10/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java: http://gerrit.cloudera.org:8080/#/c/16031/10/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java@200 PS10, Line 200: tableMetadata.getSchema() nit: since those fields are option in proto file, maybe it's worth adding a sanity check Preconditions.checkNotNull or alike? http://gerrit.cloudera.org:8080/#/c/16031/10/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/16031/10/src/kudu/client/scan_token-internal.cc@282 PS10, Line 282: table_pb.mutable_partition_schema()->CopyFrom(partition_schema_pb); nit: use std::move() here as well? http://gerrit.cloudera.org:8080/#/c/16031/10/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/16031/10/src/kudu/client/scan_token-test.cc@759 PS10, Line 759: int init_requests = METRIC_handler_latency_kudu_master_MasterService_GetTableSchema nit: add 'const' ? http://gerrit.cloudera.org:8080/#/c/16031/10/src/kudu/client/scan_token-test.cc@764 PS10, Line 764: METRIC_handler_latency_kudu_master_MasterService_GetTableSchema : .Instantiate(ent) nit: for better readability, maybe introduce a variable for this (a const pointer?) and use it these 3 places? -- To view, visit http://gerrit.cloudera.org:8080/16031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c1b8392de37dd5e8b7bd8b78a21603ff8b1d1b Gerrit-Change-Number: 16031 Gerrit-PatchSet: 10 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2020 19:22:48 +0000 Gerrit-HasComments: Yes
