Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16063 )
Change subject: [util] improved performance of BlockingQueue ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16063/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16063/1//COMMIT_MSG@10 PS1, Line 10: semantics. Switched from std::list to std::dequeue for the underlying > actually it looks like it's onyl really used by Log in a perf-sensitive spo Yep, it's used in Log (and in SubprocessServer, but the latter isn't performance-sensitive as I can see). http://gerrit.cloudera.org:8080/#/c/16063/1//COMMIT_MSG@10 PS1, Line 10: semantics. Switched from std::list to std::dequeue for the underlying > I think BlockingQueue is used in a bunch of high-throughput scenarios. I'm It's a very good point, thank you! Indeed, I added a performance test in https://gerrit.cloudera.org/#/c/16064/ and it claims significant performance improvement. I added more details into the commit message. -- To view, visit http://gerrit.cloudera.org:8080/16063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie80620e5e86cd72c29320096dcdcc712eea1b0f2 Gerrit-Change-Number: 16063 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 11 Jun 2020 04:25:38 +0000 Gerrit-HasComments: Yes
