Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16063 )
Change subject: [util] clean up on BlockingQueue ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16063/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16063/1//COMMIT_MSG@10 PS1, Line 10: semantics. Switched from std::list to std::dequeue for the underlying I think BlockingQueue is used in a bunch of high-throughput scenarios. I'm not sure if Deque is better/worse than List but I think such a change should probably include some benchmarking and not sneak into "clean up" -- To view, visit http://gerrit.cloudera.org:8080/16063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie80620e5e86cd72c29320096dcdcc712eea1b0f2 Gerrit-Change-Number: 16063 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 10 Jun 2020 22:00:08 +0000 Gerrit-HasComments: Yes
