Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16049 )

Change subject: KUDU-3145 Skip old gold in our list of candidate linkers
......................................................................


Patch Set 2:

(5 comments)

Thank you very much for the fix!

This patch looks good to me.  Could you fix few style nits in the commit 
message?

http://gerrit.cloudera.org:8080/#/c/16049/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16049/2//COMMIT_MSG@9
PS2, Line 9:
nit: trailing space


http://gerrit.cloudera.org:8080/#/c/16049/2//COMMIT_MSG@10
PS2, Line 10:
ditto


http://gerrit.cloudera.org:8080/#/c/16049/2//COMMIT_MSG@11
PS2, Line 11:
ditto


http://gerrit.cloudera.org:8080/#/c/16049/2//COMMIT_MSG@14
PS2, Line 14: codes of
nit: drop


http://gerrit.cloudera.org:8080/#/c/16049/2//COMMIT_MSG@14
PS2, Line 14: linkers selecting
nit: choosing the linker



--
To view, visit http://gerrit.cloudera.org:8080/16049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d7dbd6a828f14a6790be657b0f497a4887a6f82
Gerrit-Change-Number: 16049
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Fri, 12 Jun 2020 05:17:26 +0000
Gerrit-HasComments: Yes

Reply via email to