Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16049 )
Change subject: KUDU-3145 Skip old gold in our list of candidate linkers ...................................................................... KUDU-3145 Skip old gold in our list of candidate linkers Older versions of the gold linker are vulnerable to a bug which prevents weak symbols from being overridden properly. This leads to omitting of Kudu's tcmalloc dependency if using dynamic linking, and some related tests failed in DEBUG build mode. This change moves KUDU_LINK setting before choosing the linker to make sure to skip old gold if using dynamic linking. Change-Id: I2d7dbd6a828f14a6790be657b0f497a4887a6f82 Reviewed-on: http://gerrit.cloudera.org:8080/16049 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M CMakeLists.txt 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2d7dbd6a828f14a6790be657b0f497a4887a6f82 Gerrit-Change-Number: 16049 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]>
