Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16075 )
Change subject: [consensus] use move semantics for LogEntryBatchPB ...................................................................... Patch Set 1: Verified+1 (2 comments) Unrelated failures in a couple of tests: * ClientFailoverTServerTimeoutITest.FailoverOnLeaderTimeout: timeout creating table * CreateTableITest.TestCreateWhenMajorityOfReplicasFailCreation: failed to start chronyd http://gerrit.cloudera.org:8080/#/c/16075/1/src/kudu/consensus/log_util.cc File src/kudu/consensus/log_util.cc: http://gerrit.cloudera.org:8080/#/c/16075/1/src/kudu/consensus/log_util.cc@708 PS1, Line 708: *offset, header.msg_length)); > warning: 1st function call argument is an uninitialized value [clang-analyz I'm going to ignore this garbage warning from TidyBot. http://gerrit.cloudera.org:8080/#/c/16075/1/src/kudu/consensus/log_util.cc@709 PS1, Line 709: if (header.msg_length == 0) { > warning: The left operand of '==' is a garbage value [clang-analyzer-core.U ditto -- To view, visit http://gerrit.cloudera.org:8080/16075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5d3c384dd6f17e8c4c71eec074af9e98827262b Gerrit-Change-Number: 16075 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 13 Jun 2020 05:56:14 +0000 Gerrit-HasComments: Yes
