Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/16075 )
Change subject: [consensus] use move semantics for LogEntryBatchPB
......................................................................
Patch Set 1:
> Would be nice to quantify the perf improvement for this. While heap
> allocation might be expensive, iiuc moving PBs entails trivial
> copies on move, which might add up, vs pointer swizzling.
I added a blurb on the measured performance impact for this patch in PS2. We
don't have a targeted low-level unit test to assess these kind of thinks for
consensus/log.{cc,h}, but I ran mt-log-test as a synthetic benchmark.
--
To view, visit http://gerrit.cloudera.org:8080/16075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5d3c384dd6f17e8c4c71eec074af9e98827262b
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 15 Jun 2020 03:49:35 +0000
Gerrit-HasComments: No
