Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16034 )
Change subject: WIP [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm() ...................................................................... Patch Set 2: (2 comments) Interesting trick to atomically store/retrieve 2 variables. Just some minor comments. http://gerrit.cloudera.org:8080/#/c/16034/2/src/kudu/consensus/consensus_meta.cc File src/kudu/consensus/consensus_meta.cc: http://gerrit.cloudera.org:8080/#/c/16034/2/src/kudu/consensus/consensus_meta.cc@61 PS2, Line 61: constexpr size_t kPackedRoleBits = 3; Worth adding an acsii diagram of how the role and term bits are packed including bit widths for each. http://gerrit.cloudera.org:8080/#/c/16034/2/src/kudu/consensus/consensus_meta.cc@75 PS2, Line 75: crush typo -- To view, visit http://gerrit.cloudera.org:8080/16034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I934ae3035d893fd850afe27d96f8dd6612c9ffbd Gerrit-Change-Number: 16034 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 17 Jun 2020 23:40:31 +0000 Gerrit-HasComments: Yes
