Bankim Bhavsar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16034 )

Change subject: [consensus] KUDU-2727 lock-free CheckLeadershipAndBindTerm()
......................................................................


Patch Set 5:

(1 comment)

LGTM but don't have enough background to vote on the change.

http://gerrit.cloudera.org:8080/#/c/16034/5/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

http://gerrit.cloudera.org:8080/#/c/16034/5/src/kudu/consensus/raft_consensus.cc@201
PS5, Line 201: LockGuard l(lock_);
Why is the lock needed now?



--
To view, visit http://gerrit.cloudera.org:8080/16034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I934ae3035d893fd850afe27d96f8dd6612c9ffbd
Gerrit-Change-Number: 16034
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 19 Jun 2020 17:17:18 +0000
Gerrit-HasComments: Yes

Reply via email to