Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16101 )
Change subject: [client] KUDU-3152 fix predicates on DATE column ...................................................................... Patch Set 1: (1 comment) > (1 comment) > > It seems the failures in DenseNodeTest.RunTest and > MultiMasterIdleConnectionsITest are not relevant. However, LINT > build points to a style issue. Done. Thanks for pointing this out. http://gerrit.cloudera.org:8080/#/c/16101/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java: http://gerrit.cloudera.org:8080/#/c/16101/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java@1288 PS1, Line 1288: Assert.assertEquals("`date` IS NULL", KuduPredicate.newIsNullPredicate(dateCol).toString()); > Does it make sense to add a case to verify how 'NOT NULL' predicate convert Done -- To view, visit http://gerrit.cloudera.org:8080/16101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2759f1228852b78075bd5278f8f1efd19d0d029e Gerrit-Change-Number: 16101 Gerrit-PatchSet: 1 Gerrit-Owner: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 23 Jun 2020 18:12:25 +0000 Gerrit-HasComments: Yes
