Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16101 )
Change subject: [client] KUDU-3152 fix predicates on DATE column ...................................................................... Patch Set 3: > > Patch Set 3: > > > > Looking at the C++ client for comparison and in list predicate it > uses a data type 'KuduValue'. I don't see a mechanism to convert > DATE datatype and perhaps VARCHAR too to KuduValue. So that needs > fixing as well. > > My bad, DATE is just a special case of int32. > Lack of KuduValue::FromDate() does seem like it's missing. I am guessing you are referring to C++ client. What argument type will KuduValue::FromDate() take? -- To view, visit http://gerrit.cloudera.org:8080/16101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2759f1228852b78075bd5278f8f1efd19d0d029e Gerrit-Change-Number: 16101 Gerrit-PatchSet: 3 Gerrit-Owner: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 23 Jun 2020 20:55:17 +0000 Gerrit-HasComments: No