Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16044 )
Change subject: KUDU-2612 p2: introduce transaction status management ...................................................................... Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_entry.h File src/kudu/transactions/status_entry.h: http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_entry.h@105 PS2, Line 105: > Does it make sense to use unordered_map here instead? If GetParticipantIds Done You're right, order doesn't really matter here, though it does make it easier on tests. http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_entry.cc File src/kudu/transactions/status_entry.cc: http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_entry.cc@39 PS2, Line 39: > nit: why not to have this defined and assigned at the same line? Done http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_entry.cc@53 PS2, Line 53: > nit: add Ack http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_entry.cc@54 PS2, Line 54: : : > nit: consider using AppendKeysFromMap() (it has a specialization for std::v Done http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_manager-test.cc File src/kudu/transactions/status_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_manager-test.cc@383 PS2, Line 383: > Does it make sense to verify how BeginCommitTransaction() works on already Done http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_manager-test.cc@391 PS2, Line 391: > Does it make sense to add a scenario trying to register a participant when Done http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_manager.h File src/kudu/transactions/status_manager.h: http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_manager.h@19 PS2, Line 19: > nit: use <cstdint> instead Done http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_manager.cc File src/kudu/transactions/status_manager.cc: http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/transactions/status_manager.cc@123 PS2, Line 123: > What if there was a race and there is a record with higher transaction ID a It's safe as long as no two callers of this function return success for the same txn_id. I'll add that to the header description and as a note here. http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/util/cow_object.h File src/kudu/util/cow_object.h: http://gerrit.cloudera.org:8080/#/c/16044/2/src/kudu/util/cow_object.h@437 PS2, Line 437: // Helper to manage locking on the metadata protected by a CowLock. > Thank you for adding this doc! Np, I found it difficult to follow the master's usage at first, so thought it would be helpful here. -- To view, visit http://gerrit.cloudera.org:8080/16044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I371bb200cf65073ae3ac7cb311ab9a0b8344a636 Gerrit-Change-Number: 16044 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 25 Jun 2020 23:25:10 +0000 Gerrit-HasComments: Yes
