Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16044 )
Change subject: KUDU-2612 p2: introduce transaction status management ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/16044/3/src/kudu/transactions/txn_status_entry.h File src/kudu/transactions/txn_status_entry.h: http://gerrit.cloudera.org:8080/#/c/16044/3/src/kudu/transactions/txn_status_entry.h@76 PS3, Line 76: : txn_id_(txn_id), > warning: pass by value and use std::move [modernize-pass-by-value] Done http://gerrit.cloudera.org:8080/#/c/16044/3/src/kudu/transactions/txn_status_manager-test.cc File src/kudu/transactions/txn_status_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16044/3/src/kudu/transactions/txn_status_manager-test.cc@175 PS3, Line 175: // barriers. > warning: 'emplace_back' is called inside a loop; consider pre-allocating th Done http://gerrit.cloudera.org:8080/#/c/16044/3/src/kudu/transactions/txn_status_manager-test.cc@178 PS3, Line 178: for (int i = 0; i < kParallelTxnsPerBatch; i++) { > warning: 'emplace_back' is called inside a loop; consider pre-allocating th Done http://gerrit.cloudera.org:8080/#/c/16044/3/src/kudu/transactions/txn_status_manager-test.cc@229 PS3, Line 229: s = txn_manager_->RegisterParticipant(kTxnId, prt, kOwner); > warning: std::move of the const variable 'prt' has no effect; remove std::m Done http://gerrit.cloudera.org:8080/#/c/16044/3/src/kudu/transactions/txn_status_manager-test.cc@279 PS3, Line 279: vector<thread> threads; > warning: 'emplace_back' is called inside a loop; consider pre-allocating th Done http://gerrit.cloudera.org:8080/#/c/16044/3/src/kudu/transactions/txn_status_manager.h File src/kudu/transactions/txn_status_manager.h: http://gerrit.cloudera.org:8080/#/c/16044/3/src/kudu/transactions/txn_status_manager.h@67 PS3, Line 67: explicit TxnStatusManager(tablet::TabletReplica* tablet_replica) > warning: single-argument constructors must be marked explicit to avoid unin Done http://gerrit.cloudera.org:8080/#/c/16044/3/src/kudu/transactions/txn_status_manager.cc File src/kudu/transactions/txn_status_manager.cc: http://gerrit.cloudera.org:8080/#/c/16044/3/src/kudu/transactions/txn_status_manager.cc@37 PS3, Line 37: using std::vector; > warning: using decl 'map' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/16044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I371bb200cf65073ae3ac7cb311ab9a0b8344a636 Gerrit-Change-Number: 16044 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 26 Jun 2020 18:01:29 +0000 Gerrit-HasComments: Yes
