Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16071 )
Change subject: KUDU-3090 Add delegate admin privilege ...................................................................... Patch Set 6: (1 comment) > Patch Set 4: > > (7 comments) > > > Patch Set 4: > > > > (8 comments) > > > > We can probably break this out of the relation chain so it doesn't depend > > on the owner patch. The behavior we're adding hinges on ownership in > > CreateTable RPCs (which already exists), rather than storing ownership > > under the hood. > > I guess I could break it out, but it does require > KuduTableCreator::set_owner() which I just moved to the owner patch. Do you > think it's worth moving it here or to a separate patch and add tests? Ah I see -- I saw 'owner' defined in the protobuf and assumed the client supported it. Yeah I'd be happy with separating that into its own patch with some tests. Should be pretty small compared to the big ownership patch, and that way we can merge this patch without blocking on all the work listed in the big patch. http://gerrit.cloudera.org:8080/#/c/16071/4/src/kudu/ranger/ranger.proto File src/kudu/ranger/ranger.proto: http://gerrit.cloudera.org:8080/#/c/16071/4/src/kudu/ranger/ranger.proto@71 PS4, Line 71: delegate admin privilege i > Given the vast number of admins that appear to exist in Ranger[1], let's be Done -- To view, visit http://gerrit.cloudera.org:8080/16071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8ba018dac568a1ab74cf2d5657221579636ac1c Gerrit-Change-Number: 16071 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 26 Jun 2020 16:59:32 +0000 Gerrit-HasComments: Yes
