Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16071 )
Change subject: KUDU-3090 Add delegate admin privilege ...................................................................... Patch Set 6: Code-Review+2 (1 comment) > Patch Set 6: > > > Patch Set 6: > > > > (1 comment) > > > > > Patch Set 4: > > > > > > (7 comments) > > > > > > > Patch Set 4: > > > > > > > > (8 comments) > > > > > > > > We can probably break this out of the relation chain so it doesn't > > > > depend on the owner patch. The behavior we're adding hinges on > > > > ownership in CreateTable RPCs (which already exists), rather than > > > > storing ownership under the hood. > > > > > > I guess I could break it out, but it does require > > > KuduTableCreator::set_owner() which I just moved to the owner patch. Do > > > you think it's worth moving it here or to a separate patch and add tests? > > > > Ah I see -- I saw 'owner' defined in the protobuf and assumed the client > > supported it. Yeah I'd be happy with separating that into its own patch > > with some tests. Should be pretty small compared to the big ownership > > patch, and that way we can merge this patch without blocking on all the > > work listed in the big patch. > > Hm as I still have to work on Grant's patch anyway, and it shouldn't take too > long either, I think it's actually better to leave it in that patch as I feel > it fits there naturally. We can wait with merging these patches until that > work is finished. K SGTM. http://gerrit.cloudera.org:8080/#/c/16071/4/src/kudu/ranger/ranger_client-test.cc File src/kudu/ranger/ranger_client-test.cc: http://gerrit.cloudera.org:8080/#/c/16071/4/src/kudu/ranger/ranger_client-test.cc@398 PS4, Line 398: > They don't, it doesn't matter. Changed to false. Mind changing the rest to 'false' too? The fact that they're different draws questions as a reader of this code. -- To view, visit http://gerrit.cloudera.org:8080/16071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8ba018dac568a1ab74cf2d5657221579636ac1c Gerrit-Change-Number: 16071 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 29 Jun 2020 17:00:35 +0000 Gerrit-HasComments: Yes
