Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16114 )
Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6 ...................................................................... Patch Set 1: > Patch Set 1: > > Why not just recommend devtoolset-6 or whatever is the newest available now? > ie even though we'll continue to support the older compiler version (for > Ubuntu 14 or 16 or whatever) there's no harm in using a newer one, and in > fact it generates better/faster code, right? That's a good point. IIUC the plan is to upgrade the devtoolset version for el6 when we bump up the minimum compiler version to support newer C++ standards across the board. This change is a quick workaround but thinking further looks like we need a release to publish these docs. Is that right? On top of my head things that'll need to be done to bump up devtoolset version requirement for el6 without tying it to min compiler version upgrade initiative: - enable_devtoolset.sh script - Test with kudu built using newer devtoolset version on el6. Let me know what folks think. -- To view, visit http://gerrit.cloudera.org:8080/16114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c4b9546c835df26f993ed6164e92f2d4c55c3fe Gerrit-Change-Number: 16114 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 26 Jun 2020 18:58:36 +0000 Gerrit-HasComments: No
