Bankim Bhavsar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16114 )

Change subject: [docs][docker] KUDU-3159 Fix missing devtoolset3 package on el6
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/16114/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16114/2//COMMIT_MSG@12
PS2, Line 12: copr repository
> nit: repositories
Done


http://gerrit.cloudera.org:8080/#/c/16114/2//COMMIT_MSG@16
PS2, Line 16: Seperate
> nit: Separate
Done


http://gerrit.cloudera.org:8080/#/c/16114/2//COMMIT_MSG@25
PS2, Line 25: Unfortunately while building thirdparty docker engine stop/gives 
error
            : after some time.
            : "failed to dial gRPC: unable to upgrade to h2c, received 502"
> I think we can look into this issue separately. It's definitely not related
Yeah this looks like an unrelated issue.


http://gerrit.cloudera.org:8080/#/c/16114/2/docker/bootstrap-dev-env.sh
File docker/bootstrap-dev-env.sh:

http://gerrit.cloudera.org:8080/#/c/16114/2/docker/bootstrap-dev-env.sh@103
PS2, Line 103: 
DTLS_REPO_URL=https://copr.fedorainfracloud.org/coprs/rhscl/devtoolset-3/repo/epel-6/rhscl-devtoolset-3-epel-6.repo
> Feel free to ignore this: it's just a nit.
It helps keep the yum-config-manager shorter and in case this URL needs to be 
updated, it's easier.



--
To view, visit http://gerrit.cloudera.org:8080/16114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c4b9546c835df26f993ed6164e92f2d4c55c3fe
Gerrit-Change-Number: 16114
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Wed, 08 Jul 2020 17:13:45 +0000
Gerrit-HasComments: Yes

Reply via email to