Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16126 )
Change subject: KUDU-3090 Support backing up ownership info ...................................................................... Patch Set 6: > Patch Set 4: Code-Review+2 > > Are you planning to add a flag to the restore job to ignore the owner on > default and restore as the user who runs the restore job? > > That would be useful now that the restore job requires potentially more > privileges than before. Tbh I'm not sure what the correct behavior would be here. It could be considered a breaking change whatever we do: 1) if we leave it as is, then higher level of privilege is required to perform the same action in the new version 2) if we add a flag to disregard owners and restore everything without setting the owner explicitly (the user running the script will be owner of every table), but we don't make it the default, then we still have the same problem, we just add a workaround. 3) if we add a flag to preserve owner but change the default behavior, then we're not actually doing what the user might expect (backing up and restoring all metadata). -- To view, visit http://gerrit.cloudera.org:8080/16126 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I963db0a36cd4b7f080944ed46fc4119b1e055143 Gerrit-Change-Number: 16126 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 06 Jul 2020 16:18:03 +0000 Gerrit-HasComments: No
