Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16126 )
Change subject: KUDU-3090 Support backing up ownership info ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/16126/7/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/16126/7/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@747 PS7, Line 747: def validateTablesMatch(tableA: String, tableB: String): Unit = { Does it also make sense to test restoring a table that has had its owner changed mid-way through inserting rows? http://gerrit.cloudera.org:8080/#/c/16126/7/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@750 PS7, Line 750: assertEquals(tA.getOwner, tB.getOwner) nit: maybe also check that the owner isn't empty? -- To view, visit http://gerrit.cloudera.org:8080/16126 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I963db0a36cd4b7f080944ed46fc4119b1e055143 Gerrit-Change-Number: 16126 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 08 Jul 2020 02:14:27 +0000 Gerrit-HasComments: Yes
