Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16145 )

Change subject: test: fix flakiness of TestDeletedRowsetGc
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16145/1/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:

http://gerrit.cloudera.org:8080/#/c/16145/1/src/kudu/util/env_posix.cc@1634
PS1, Line 1634: LOG(WARNING) << "Error running callback with file " << 
ent->fts_path
              :                        << " during walk: " << s.ToString();
nit: would Substitute() be a better fit to format the message here?



--
To view, visit http://gerrit.cloudera.org:8080/16145
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2b2583d984c7cca1a747920095e4dbafde9cad9
Gerrit-Change-Number: 16145
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 06 Jul 2020 20:31:36 +0000
Gerrit-HasComments: Yes

Reply via email to