Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16145
to look at the new patch set (#2).
Change subject: test: fix flakiness of TestDeletedRowsetGc
......................................................................
test: fix flakiness of TestDeletedRowsetGc
The test would sometimes fail (4/100 times in debug mode) with the following
newly added log lines:
W0706 19:48:08.251113 4454 env_posix.cc:1634] Error running callback with file
/tmp/dist-test-taskGX39QD/test-tmp/tablet_history_gc-itest.0.TabletHistoryGcITest.TestDeletedRowsetGc.1594064887277463-4454/minicluster-data/ts-0-root/tablet-meta/57ca68c74fa94632b1acffbc547afa4c.kudutmp.308Cez
during walk: Not found:
/tmp/dist-test-taskGX39QD/test-tmp/tablet_history_gc-itest.0.TabletHistoryGcITest.TestDeletedRowsetGc.1594064887277463-4454/minicluster-data/ts-0-root/tablet-meta/57ca68c74fa94632b1acffbc547afa4c.kudutmp.308Cez:
No such file or directory (error 2)
../../src/kudu/integration-tests/tablet_history_gc-itest.cc:327: Failure
Failed
Bad status: IO error:
/tmp/dist-test-taskGX39QD/test-tmp/tablet_history_gc-itest.0.TabletHistoryGcITest.TestDeletedRowsetGc.1594064887277463-4454/minicluster-data/ts-0-root:
One or more errors occurred
It seems recursing through the file system isn't a great idea when
maintenance ops are running in the background. This addresses the issue
by asserting eventual success.
With this patch, the test succeeded 1000/1000 times in debug mode.
Change-Id: If2b2583d984c7cca1a747920095e4dbafde9cad9
---
M src/kudu/integration-tests/tablet_history_gc-itest.cc
M src/kudu/util/env_posix.cc
2 files changed, 17 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/16145/2
--
To view, visit http://gerrit.cloudera.org:8080/16145
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If2b2583d984c7cca1a747920095e4dbafde9cad9
Gerrit-Change-Number: 16145
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
