Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16136 )
Change subject: Enable arenas for RPC request and response ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/16136/4/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/16136/4/src/kudu/consensus/raft_consensus.cc@1312 PS4, Line 1312: break > Maybe, return right from here? Done http://gerrit.cloudera.org:8080/#/c/16136/4/src/kudu/consensus/raft_consensus.cc@1317 PS4, Line 1317: RETURN_NOT_OK(s); > If returning non-OK status at line 1312, then drop this ? Done http://gerrit.cloudera.org:8080/#/c/16136/4/src/kudu/rpc/rpc_context.h File src/kudu/rpc/rpc_context.h: http://gerrit.cloudera.org:8080/#/c/16136/4/src/kudu/rpc/rpc_context.h@203 PS4, Line 203: > style nit: stick asterisk to the type ? Done http://gerrit.cloudera.org:8080/#/c/16136/4/src/kudu/rpc/rpc_context.h@204 PS4, Line 204: > ditto Done http://gerrit.cloudera.org:8080/#/c/16136/4/src/kudu/rpc/rpc_context.h@245 PS4, Line 245: const google::protobuf::Message* request_pb_ > Since request_pb_ is never changed, maybe Done http://gerrit.cloudera.org:8080/#/c/16136/4/src/kudu/rpc/rpc_context.h@246 PS4, Line 246: google::protobuf::Message* response_pb_ > Since response_pb_ is never changed, maybe Done http://gerrit.cloudera.org:8080/#/c/16136/4/src/kudu/rpc/service_if.cc File src/kudu/rpc/service_if.cc: http://gerrit.cloudera.org:8080/#/c/16136/4/src/kudu/rpc/service_if.cc@107 PS4, Line 107: CHECK(call->pb_arena()); > When it might ever trigger if InboundCall contains Arena as a member and In just removed it, i think it was leftover from some intermediate version of my patch -- To view, visit http://gerrit.cloudera.org:8080/16136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I810931900fc2b5f1dec1265abadfb33fb41d29bf Gerrit-Change-Number: 16136 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 07 Jul 2020 22:10:08 +0000 Gerrit-HasComments: Yes
