Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )
Change subject: KUDU-3090 Add ownership privileges ...................................................................... Patch Set 21: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc@831 PS19, Line 831: // We need to grant metadata permissions to kTestUser, otherwise alter table : // would time out due to lack of privileges running IsAlterTableInProgress(). > What do you mean? OpenTable() would fail if we didn't have METADATA which w Ah, seems I misunderstood this comment. I thought the timeout would come in the second Alter() call made by the original owner, but I think you're referring to the first call. Since there are a few alter tables in this test, would you mind clarifying the comment, e.g "We need to grant metadata permissions to the user, otherwise the ownership change would time out due to lack of privileges when checking the alter table progress." -- To view, visit http://gerrit.cloudera.org:8080/16072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109 Gerrit-Change-Number: 16072 Gerrit-PatchSet: 21 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 10 Jul 2020 19:39:29 +0000 Gerrit-HasComments: Yes
