Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )
Change subject: KUDU-3090 Add ownership privileges ...................................................................... Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc@1063 PS15, Line 1063: : kTableName, : "" : }, : { : { > Unfortunately that doesn't work, kTestUser contains a hyphen which is an in Regardless, this returns empty if get<2> is neither kTestUser nor {OWNER}. How about doing something like std::get<2>(info.param) == "{OWNER}" ? "owner" : "nonowner" That way it's decoupled from the actual test username while still being clear what we're testing http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc@831 PS19, Line 831: // We need to grant metadata permissions to kTestUser, otherwise alter table : // would time out due to lack of privileges running IsAlterTableInProgress(). Alternatively, would OpenTable() fail with an authz error after transferring ownership? http://gerrit.cloudera.org:8080/#/c/16072/19/src/kudu/integration-tests/master_authz-itest.cc@834 PS19, Line 834: tableName nit: snake_case for variable names Also could be const -- To view, visit http://gerrit.cloudera.org:8080/16072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109 Gerrit-Change-Number: 16072 Gerrit-PatchSet: 19 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 10 Jul 2020 18:16:12 +0000 Gerrit-HasComments: Yes
