Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16113 )
Change subject: KUDU-3090 Restrict changing ownership of a table ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/16113/14/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16113/14/src/kudu/integration-tests/master_authz-itest.cc@1099 PS14, Line 1099: kTableName, : "" : }, : { : { : &MasterAuthzITestBase::GetTabletLocations, : &MasterAuthzITestBase::GrantGetMetadataTablePrivilege, : "GetTabletLocations", : > We should have test cases for the following behaviors too: The 'user is the owner' case is tested by this test case actually, as it tries to authorize changing ownership before granting permissions AllWithGrant to {OWNER}, but kTestUser is the owner in all of these cases. Created a test for the other two scenarios, but they have to be their own test as these authz combinations work in a way that there are no permissions granted at all and the action fails, then a permission is granted and the same action succeed. -- To view, visit http://gerrit.cloudera.org:8080/16113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75a8b24364572a84f93826ad670c543abd407bb1 Gerrit-Change-Number: 16113 Gerrit-PatchSet: 16 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 14 Jul 2020 16:30:08 +0000 Gerrit-HasComments: Yes
