Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16113 )
Change subject: KUDU-3090 Restrict changing ownership of a table ...................................................................... Patch Set 18: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16113/18/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16113/18/src/kudu/master/catalog_manager.cc@2615 PS18, Line 2615: // Change owner requires higher level of privilege (ALL WITH GRANT OPTION, : // or ALL + delegate admin) than other types of alter operations, so if a : // single alter contains an owner change as well as other changes, it's : // sufficient to authorize only the owner change. Thanks for adding this! It's probably also worth adding a test for this -- that if we alter the table and change ownership at the same time, we can't do so unless we have ALL assigned. -- To view, visit http://gerrit.cloudera.org:8080/16113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75a8b24364572a84f93826ad670c543abd407bb1 Gerrit-Change-Number: 16113 Gerrit-PatchSet: 18 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 15 Jul 2020 18:56:43 +0000 Gerrit-HasComments: Yes
