Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15995 )
Change subject: [maintenance] use workload statistics to scale perf score of flushes/compactions ...................................................................... Patch Set 14: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/15995/14/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/15995/14/src/kudu/tserver/tablet_server-test.cc@4348 PS14, Line 4348: // Wait for the flag to take effect and compaction in the cold tablet to complete. I ran this test 100 times and it failed 14 times because 2 seconds isn't always enough. See them here: http://dist-test.cloudera.org/job?job_id=awong.1596229700.32746 How about just wrapping this ASSERT_EQ() in an ASSERT_EVENTUALLY(), without the SleepFor()? -- To view, visit http://gerrit.cloudera.org:8080/15995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3afcc359002d1392164ba2fda885f8930ef8696 Gerrit-Change-Number: 15995 Gerrit-PatchSet: 14 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 31 Jul 2020 21:20:58 +0000 Gerrit-HasComments: Yes
