Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15995 )
Change subject: [maintenance] use workload statistics to scale perf score of flushes/compactions ...................................................................... Patch Set 15: Code-Review+1 (2 comments) Just a couple more nits http://gerrit.cloudera.org:8080/#/c/15995/15/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/15995/15/src/kudu/tablet/tablet.cc@159 PS15, Line 159: metrics nit: workload metrics http://gerrit.cloudera.org:8080/#/c/15995/15/src/kudu/tablet/tablet.cc@2099 PS15, Line 2099: last_rows_inserted_ = metrics_->rows_inserted->value(); : last_rows_upserted_ = metrics_->rows_upserted->value(); : last_rows_updated_ = metrics_->rows_updated->value(); : last_rows_deleted_ = metrics_->rows_deleted->value(); nit: We could probably get by with just a single `last_rows_mutated_` -- that way we wouldn't have to maintain counters for each of these. -- To view, visit http://gerrit.cloudera.org:8080/15995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3afcc359002d1392164ba2fda885f8930ef8696 Gerrit-Change-Number: 15995 Gerrit-PatchSet: 15 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 01 Aug 2020 00:10:09 +0000 Gerrit-HasComments: Yes
