Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16284 )
Change subject: [benchmarks] added a few 'perf stat' metrics ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16284/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16284/3//COMMIT_MSG@11 PS3, Line 11: * instructions per cycle : * CPU utilization : * branch misses > These are useful in getting to the bottom of why something is slow. Have yo >From what I could see, these are relatively stable. Otherwise I wouldn't use >them. IPC usually varies less than 2% run to run; the variation of other two are usually under 5%. Instructions per cycle provides a good measure on how efficient the code is. You can get more info on that at (grep for IPC): http://www.brendangregg.com/blog/2017-05-09/cpu-utilization-is-wrong.html Yes, those provide more coverage than test-specific application metrics since they show how efficiently hardware resources are used. http://gerrit.cloudera.org:8080/#/c/16284/3/src/kudu/scripts/benchmarks.sh File src/kudu/scripts/benchmarks.sh: http://gerrit.cloudera.org:8080/#/c/16284/3/src/kudu/scripts/benchmarks.sh@573 PS3, Line 573: # parse scan timings for scans and inserts with MRS only > We aren't collecting stats for a few of these tests. Was that deliberate? W Yes, that's deliberate. We aren't collecting stats for these full_stack-insert-scan-test because I tried to use the provisions for --perf_stat_scan and those aren't working. I added TODO for those. In addition, we aren't collecting these stats for tests running external mini-cluster. As you can see, there are also TODOs for these as well above. -- To view, visit http://gerrit.cloudera.org:8080/16284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib742ffbaabca96c2ac455481313348da2133ff6e Gerrit-Change-Number: 16284 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 10 Aug 2020 20:55:55 +0000 Gerrit-HasComments: Yes
